Fix for diskless installation (bsc#1260378)#3364
Conversation
teclator
force-pushed
the
fix_diskless_inst
branch
from
4fe0e5d to
460d306
Compare
| - Fix for diskless installation making a proposal when | ||
| there is at least the product configuration notifying the | ||
| system and proposal state (bsc#1260378). |
There was a problem hiding this comment.
NP: Too coupled to the implementation detail, IMHO.
What about just saying in the line of "Always update system and proposal state to avoid progress stalling, even when status hasn’t changed after an action."?
In any case, feel free to keep it as it is.
There was a problem hiding this comment.
What about just saying in the line of "Always update system and proposal state to avoid progress stalling, even when status hasn’t changed after an action."?
Reading it twice it is kind of coupled as well, and probably "update" is not the right word, but it was just an example for trying to make the changelog entry a bit more for humans. Details are in the code itself and in the bug report. Better to express what it fix/prevents.
Prepare to release version 20. * #3294 * #3295 * #3296 * #3297 * #3298 * #3299 * #3300 * #3301 * #3302 * #3303 * #3304 * #3305 * #3306 * #3307 * #3308 * #3309 * #3310 * #3311 * #3312 * #3313 * #3315 * #3316 * #3317 * #3318 * #3319 * #3320 * #3322 * #3323 * #3325 * #3326 * #3327 * #3329 * #3330 * #3331 * #3333 * #3334 * #3336 * #3338 * #3339 * #3342 * #3343 * #3349 * #3351 * #3352 * #3353 * #3354 * #3356 * #3357 * #3358 * #3359 * #3360 * #3361 * #3362 * #3363 * #3364 * #3365 * #3366 * #3367 * #3368 * #3371 * #3372 * #3373 * #3375 * #3376 * #3378 * #3379 * #3380 * #3381 * #3382 * #3385 * #3386
3 participants
Problem
If the system has no devices when it starts (diskless system), then the storage proposal is not automatically calculated after activating new devices (zFCP, DASD, iSCSI).
Solution
Fix the condition to make a proposal when at least there is a product configuration as in case of no disk there is no proposal at all.
Apart of that we fixed an issue with the UI that caused the progress backdrop ("Refreshing data") to be shown when it actually finished because it also waits for proposal changes (related to web: refactor progress backdrop query tracking #2958)
Testing